Skip to content

Conversation

FrankD412
Copy link
Collaborator

Description

Fixes an incorrect function for converting generation token/sec/user in trtllm-bench.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Frank Di Natale <[email protected]>
@FrankD412 FrankD412 self-assigned this May 7, 2025
@FrankD412 FrankD412 requested review from Superjomn and kaiyux May 7, 2025 05:13
@FrankD412
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4316 [ run ] triggered by Bot

@FrankD412
Copy link
Collaborator Author

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4319 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4316 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4319 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit c489190

@FrankD412
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4325 [ run ] triggered by Bot

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn enabled auto-merge (squash) May 7, 2025 06:07
@tensorrt-cicd
Copy link
Collaborator

PR_Github #4325 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3101 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4411 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4411 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3174 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4428 [ run ] triggered by Bot

@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4435 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4428 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4435 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3195 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4591 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4591 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3305 completed with status: 'SUCCESS'

@Superjomn Superjomn merged commit 57afbf6 into NVIDIA:main May 8, 2025
3 checks passed
@FrankD412 FrankD412 deleted the trtllm-bench/fix_gen_tps_unit branch May 8, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants