Skip to content

chore: Clean up the legacy DeepseekAllreudceFusionOp. #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

chore: Clean up the legacy DeepseekAllreudceFusionOp. #4081

merged 1 commit into from
May 9, 2025

Conversation

hyukn
Copy link
Collaborator

@hyukn hyukn commented May 6, 2025

This op can now be completely replaced by the new AllReduce op.

@hyukn hyukn requested a review from hlu1 May 6, 2025 09:22
@hyukn
Copy link
Collaborator Author

hyukn commented May 6, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4182 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4182 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #2989 completed with status: 'FAILURE'

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch 2 times, most recently from 4311a50 to b0b7708 Compare May 6, 2025 10:44
@hyukn
Copy link
Collaborator Author

hyukn commented May 6, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4193 [ run ] triggered by Bot

@hyukn
Copy link
Collaborator Author

hyukn commented May 6, 2025

/bot kill

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from b0b7708 to 9f0327f Compare May 6, 2025 13:41
@tensorrt-cicd
Copy link
Collaborator

PR_Github #4217 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4193 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4217 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 9f0327f

@hyukn
Copy link
Collaborator Author

hyukn commented May 6, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4224 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4224 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3016 completed with status: 'FAILURE'

hlu1
hlu1 reviewed May 6, 2025
View reviewed changes
@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from 9f0327f to 80113ea Compare May 7, 2025 09:15
@hyukn
Copy link
Collaborator Author

hyukn commented May 7, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4358 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4358 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3127 completed with status: 'FAILURE'

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from 80113ea to 4290daf Compare May 8, 2025 05:46
@hyukn
Copy link
Collaborator Author

hyukn commented May 8, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4486 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4486 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3222 completed with status: 'FAILURE'

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from 4290daf to c225f63 Compare May 8, 2025 12:20
@hyukn
Copy link
Collaborator Author

hyukn commented May 8, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4557 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4557 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3277 completed with status: 'SUCCESS'

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from c225f63 to 4127653 Compare May 9, 2025 01:33
@hyukn
Copy link
Collaborator Author

hyukn commented May 9, 2025

/bot run

@hyukn hyukn enabled auto-merge (squash) May 9, 2025 01:35
@hyukn
Copy link
Collaborator Author

hyukn commented May 9, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4615 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4615 [ reuse-pipeline ] completed with state SUCCESS
Release Check Pipeline #790 failed
Reusing PR_Github #4557 for commit 4127653

@hyukn hyukn force-pushed the chore/cleanup_deepseek_allreduce branch from 4127653 to 4a9bff6 Compare May 9, 2025 02:01
@hyukn
Copy link
Collaborator Author

hyukn commented May 9, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4621 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4621 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #4557 for commit 4a9bff6

@hyukn hyukn merged commit 5b61486 into NVIDIA:main May 9, 2025
3 checks passed
@hyukn hyukn mentioned this pull request May 9, 2025
Merged
chzblych pushed a commit that referenced this pull request May 9, 2025
@hyukn
chore: Fix pipeline break caused by previous PR (#4081) rebase + pipe…
c9cac43 
…line reuse (#4169)

Fix import break caused by rebase.

Signed-off-by: Yukun He <[email protected]>
@hyukn hyukn deleted the chore/cleanup_deepseek_allreduce branch May 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hlu1 hlu1 hlu1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyukn @tensorrt-cicd @hlu1