Skip to content

Conversation

uchihatmtkinu
Copy link
Collaborator

@uchihatmtkinu uchihatmtkinu commented Apr 24, 2025

[TRTLLM-2795] Add yarn support for other models in trt-flow

Description

Add yarn support in trt-flow for customers requirements to enable yarn rope embedding for models other than DeepSeek models.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@uchihatmtkinu uchihatmtkinu changed the title [Draft] [TRTLLM-2795] Add yarn support for other models in trt-flow [TRTLLM-2795] Add yarn support for other models in trt-flow Apr 25, 2025
@uchihatmtkinu uchihatmtkinu force-pushed the user/zeyuw/yarn_support_trtflow branch 2 times, most recently from 70f356f to b3b7a33 Compare April 25, 2025 03:11
@dominicshanshan dominicshanshan requested a review from byshiue April 25, 2025 03:34
@uchihatmtkinu
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3348 [ run ] triggered by Bot

@uchihatmtkinu uchihatmtkinu self-assigned this Apr 25, 2025
Copy link
Collaborator

@byshiue byshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3348 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2339 completed with status: 'FAILURE'

@juney-nvidia juney-nvidia changed the title [TRTLLM-2795] Add yarn support for other models in trt-flow [TRTLLM-2795] feat: Add yarn support for other models in trt-flow Apr 26, 2025
@uchihatmtkinu uchihatmtkinu force-pushed the user/zeyuw/yarn_support_trtflow branch from b3b7a33 to e955353 Compare April 28, 2025 03:28
@uchihatmtkinu
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3578 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3578 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2518 completed with status: 'FAILURE'

@uchihatmtkinu
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3815 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3815 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2699 completed with status: 'FAILURE'

@uchihatmtkinu uchihatmtkinu force-pushed the user/zeyuw/yarn_support_trtflow branch from 37018f6 to 9520920 Compare May 6, 2025 02:13
@uchihatmtkinu
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4127 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4127 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2941 completed with status: 'FAILURE'

@StudyingShao
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4640 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4640 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3348 completed with status: 'SUCCESS'

@uchihatmtkinu uchihatmtkinu merged commit 2681b26 into NVIDIA:main May 15, 2025
3 checks passed
@uchihatmtkinu uchihatmtkinu deleted the user/zeyuw/yarn_support_trtflow branch May 15, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants