Skip to content

Support RingAttention in the BertAttention plugin and the DiT model #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Support RingAttention in the BertAttention plugin and the DiT model #3661

merged 1 commit into from
May 9, 2025

Conversation

forrestl111
Copy link
Collaborator

Support RingAttention in the BertAttention plugin and the DiT model

@nv-guomingz
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2705 [ run ] triggered by Bot

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch 2 times, most recently from f1327f1 to bd69e2a Compare April 18, 2025 02:18
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2705 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #1929 completed with status: 'FAILURE'

@forrestl111 forrestl111 marked this pull request as draft April 19, 2025 02:02
@forrestl111 forrestl111 marked this pull request as ready for review April 19, 2025 02:03
@forrestl111
Copy link
Collaborator Author

/bot run

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch 2 times, most recently from ddd70e3 to 737c0df Compare April 19, 2025 02:59
@byshiue byshiue requested review from DylanChen-NV and yuxianq April 23, 2025 09:06
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 23, 2025
View reviewed changes
yuxianq
yuxianq reviewed Apr 24, 2025
View reviewed changes
DylanChen-NV
DylanChen-NV reviewed Apr 24, 2025
View reviewed changes
DylanChen-NV
DylanChen-NV approved these changes Apr 28, 2025
View reviewed changes
@tensorrt-cicd
Copy link
Collaborator

PR_Github #4124 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4124 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #2938 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from ca8a847 to b6bb340 Compare May 7, 2025 11:08
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4372 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4372 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3138 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from b6bb340 to e807634 Compare May 7, 2025 11:55
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4373 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4373 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3139 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from e807634 to ce82378 Compare May 7, 2025 12:32
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4382 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4382 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3146 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from ce82378 to ce8276c Compare May 7, 2025 12:57
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4385 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4385 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3148 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from ce8276c to a5d0f5c Compare May 8, 2025 02:03
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4456 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4456 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3198 completed with status: 'FAILURE'

@forrestl111 forrestl111 force-pushed the feature-ring-attn branch from a5d0f5c to c1a1a39 Compare May 8, 2025 06:11
@forrestl111
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4496 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4496 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3231 completed with status: 'SUCCESS'

@byshiue byshiue merged commit 9477661 into NVIDIA:main May 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@byshiue byshiue byshiue approved these changes

@yuxianq yuxianq yuxianq approved these changes

@DylanChen-NV DylanChen-NV DylanChen-NV approved these changes

Assignees

@byshiue byshiue

@yuxianq yuxianq

@DylanChen-NV DylanChen-NV

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@forrestl111 @nv-guomingz @tensorrt-cicd @byshiue @yuxianq @DylanChen-NV