Skip to content

FOUNDATIONS: Extract MapObjectToCsv logic to virtual internal #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

FOUNDATIONS: Extract MapObjectToCsv logic to virtual internal #27

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fefbafd
FOUNDATIONS: Extract MapObjectToCsv logic out into a virtual internal…
JParkesAD May 22, 2025
daf9be6
Merge branch 'main' into users/jparkesad-foundations-mapobjecttocsv-r…
JParkesAD Jul 28, 2025
b40878f
FOUNDATIONS: Extract MapObjectToCsv logic out into a virtual internal…
JParkesAD May 22, 2025
dd23dd8
CONFIG: Bump xunit from 2.9.2 to 2.9.3
dependabot[bot] Jan 13, 2025
cadb08d
CONFIG: Bump xunit.runner.visualstudio from 2.8.2 to 3.0.2
dependabot[bot] Feb 24, 2025
c66b888
CONFIG: Bump coverlet.collector from 6.0.2 to 6.0.4
dependabot[bot] Jan 27, 2025
4450d59
Merge branch 'users/jparkesad-foundations-mapobjecttocsv-refactor' of…
JParkesAD Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion NHSISL.CsvHelperClient/Services/Foundations/CsvHelpers/CsvHelperService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,22 @@
public ValueTask<string> MapObjectToCsvAsync<T>(
List<T> @object,
bool hasHeaderRecord,
Dictionary<string, int>? fieldMappings = null,

Check warning on line 48 in NHSISL.CsvHelperClient/Services/Foundations/CsvHelpers/CsvHelperService.cs

View workflow job for this annotation

GitHub Actions / Build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 48 in NHSISL.CsvHelperClient/Services/Foundations/CsvHelpers/CsvHelperService.cs

View workflow job for this annotation

GitHub Actions / Build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 48 in NHSISL.CsvHelperClient/Services/Foundations/CsvHelpers/CsvHelperService.cs

View workflow job for this annotation

GitHub Actions / Build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Check warning on line 48 in NHSISL.CsvHelperClient/Services/Foundations/CsvHelpers/CsvHelperService.cs

View workflow job for this annotation

GitHub Actions / Build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
bool? shouldAddTrailingComma = false) =>
TryCatch(async () =>
{
ValidateMapObjectToCsvArguments(@object, hasHeaderRecord);
string csv = await GetCsvFromListOfObjectsAsync(@object, hasHeaderRecord, fieldMappings, shouldAddTrailingComma);

return await ValueTask.FromResult(csv);
});

virtual internal async ValueTask<string> GetCsvFromListOfObjectsAsync<T>(
List<T> @object,
bool hasHeaderRecord,
Dictionary<string, int> fieldMappings = null,
bool? shouldAddTrailingComma = false)
{
var type = typeof(T);
bool isPlainObject = type == typeof(object);
ValidateMapObjectToCsvArgumentCombination(isPlainObject, shouldAddTrailingComma);
Expand Down Expand Up @@ -93,6 +104,6 @@

return await ValueTask.FromResult(csv);
}
});
}
}
}
Loading