Fix: [AEA-5803] - Update the Notify KID secret to use the new (better labelled) one #2248
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildjames
changed the title
wildjames
changed the title
connoravo-nhs
requested changes
Oct 3, 2025
tstephen-nhs
added a commit
to NHSDigital/electronic-prescription-service-account-resources
that referenced
this pull request
Oct 9, 2025
## Summary - Routine Change The `Application-Name` secret should actually be set to the KID. Create a new secret with a more appropriate name. PSU PR to migrate to this new secret: NHSDigital/eps-prescription-status-update-api#2248 --------- Co-authored-by: tstephen-nhs <[email protected]>
tstephen-nhs
requested changes
Oct 9, 2025
There was a problem hiding this comment.
Do not merge until confirm NHSDigital/electronic-prescription-service-account-resources#1558 has reached production
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Updates the secret for the app KID. Also removes the conditional setting of parameter values.
account-resourcesPR to add in the new secret (must be merged first): NHSDigital/electronic-prescription-service-account-resources#1558After this is merged and deployed to
prod, this PR will delete the unused secret: NHSDigital/electronic-prescription-service-account-resources#1559