Skip to content

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented May 13, 2025

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Testing will occur once this PR is approved and merged into main.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review workflow modifications for any obvious typos.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Please complete this pull request review by [ ].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop requested a review from jaredalee May 13, 2025 15:31
@jprestop jprestop linked an issue May 13, 2025 that may be closed by this pull request
16 tasks
@jprestop jprestop changed the title Per #42, make changes per the NCAR GitHub Usage Changes form feature 42 ga workflow May 16, 2025
Copy link
Collaborator

@jaredalee jaredalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@jprestop jprestop merged commit 72936a2 into main May 17, 2025
1 check passed
@jprestop jprestop deleted the feature_42_ga_workflow branch May 17, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify GitHub Actions workflow
2 participants