Skip to content

Conversation

mattldawson
Copy link
Collaborator

Add a constructor of the TUV-x that takes a JSON or YAML string that contains all the configuration data.

@mattldawson mattldawson added this to the TUV-x Python wrapper milestone Sep 4, 2025
@mattldawson mattldawson self-assigned this Sep 4, 2025
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 16:29
@mattldawson mattldawson added the enhancement New feature or request label Sep 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new constructor for the TUV-x core that accepts a JSON/YAML string, refactoring the existing constructor structure to support both file path and configuration object inputs.

  • Refactored the core constructor interface to support both file-based and string-based configuration
  • Modified function signatures to change intent(inout) to intent(in) for read-only configuration operations
  • Removed direct file reading from the main constructor logic to improve separation of concerns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/core.F90 Refactored constructor interface to add constructor_config for config objects and renamed existing to constructor_file_path
src/util/config.F90 Changed multiple function parameters from intent(inout) to intent(in) for read-only configuration operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mattldawson mattldawson merged commit f33b7a0 into main Sep 4, 2025
18 checks passed
@mattldawson mattldawson deleted the develop-config-string branch September 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants