Skip to content

Revert "Add support for scheme w/o run phase" #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Add support for scheme w/o run phase" #550

wants to merge 1 commit into from

Conversation

dustinswales
Copy link
Member

Reverts #548

climbfuji
climbfuji requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge please (appreciate the effort though). Dusan was able to update his branch with those changes before the ufswm regression testing started.

@dustinswales
Copy link
Member Author

@climbfuji My apologies, I see the convo now.

@mkavulich mkavulich deleted the revert-548-no_run_phase branch February 12, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji climbfuji requested changes

@gold2718 gold2718 Awaiting requested review from gold2718 gold2718 is a code owner

@mwaxmonsky mwaxmonsky Awaiting requested review from mwaxmonsky mwaxmonsky is a code owner

@peverwhee peverwhee Awaiting requested review from peverwhee peverwhee is a code owner

@grantfirl grantfirl Awaiting requested review from grantfirl grantfirl is a code owner

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustinswales @climbfuji