[package-alt] rename-from improvements #24112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mdgeorge4153
changed the title
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Comment on lines
472
to
473
| root::a::b::d1 refers to { local = "../d1", ... } | ||
| root::a::c::d2 refers to { local = "../d2", ... } |
Contributor
There was a problem hiding this comment.
I don't understand the meaning of the ...
Contributor
There was a problem hiding this comment.
Is it supposed to be any other data given in the toml?
Contributor
Author
There was a problem hiding this comment.
yes. should I leave it out?
stefan-mysten
approved these changes
Oct 28, 2025
mdgeorge4153
force-pushed
the
mdgeorge/pkg-alt-local-rename-from
branch
from
eef300f to
ac57960
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
pushed a commit
to stefan-mysten/sui
that referenced
this pull request
Nov 10, 2025
Changed a few things about rename-from checks: - we only check the root package - we produce much better error messages - the legacy code paths are clearer - most of the large legacy tests have been split up and the error messages snapshotted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few things about rename-from checks:
Test plan
Updated unit tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.