MudPopover: Fix MudList Scroll Issue #11694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the `firstChild` element of the popover respects the same maximum height constraint as the popover content by setting its `maxHeight` to `newMaxHeight` instead of inherit which causes a redraw every time the mouse exits the popover.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in MudMenu where shortened lists caused unnecessary redraws when the mouse exits the popover. The fix ensures that the first child element of the popover respects the same maximum height constraint as the popover content, preventing visual jumping where scrolled items would snap back to the top.
- Sets explicit
maxHeighton the first child element instead of relying on inheritance - Eliminates redraw issues that occurred when mouse interactions triggered popover updates
- Improves user experience with nested menu navigation
|
versile2
changed the title
versile2
changed the title
This was referenced Aug 5, 2025
Closed
Closed
This was referenced Aug 14, 2025
This was referenced Aug 19, 2025
This was referenced Aug 26, 2025
This was referenced Sep 3, 2025
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the
firstChildelement of the popover respects the same maximum height constraint as the popover content by setting itsmaxHeighttonewMaxHeightinstead of inherit which causes a redraw every time the mouse exits the popover.Resolves #11667 by adjusting the max-height at the mud-list level instead of letting it inherit. When it inherits it causes a redraw which puts the top scrolled item back to the top.
You can test in PopoverFlipDirectionTest.razor with/without this change. The attached issue happens quicker and easier to reproduce since Nested Lists are separate popovers (Causing an immediate redraw every time your mouse activates a nested menu item.
Checklist:
dev).