-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MudTabs: Fix slider misalignment when component is scaled #11405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudTabs: Fix slider misalignment when component is scaled #11405
Conversation
To prevent issues with page scaling, the slider underneath a tab's position and scale are set to a percentage based on the active tabs size relative to the size of all panels.
Tests now look for the appropriate percentage value, not pixel value. Due to floating point precision errors, using BeApproxiately with a precision of 0.00001.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11405 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 465 465
Lines 14407 14407
Branches 2788 2788
=======================================
Hits 13126 13126
Misses 642 642
Partials 639 639 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice work! |
@danielchalmers |
@MattiasDeparcqB Could you create a new issue about this for me? |
|
To prevent issues with page scaling, the slider underneath a tab's position and scale are set to a percentage based on the active tabs size relative to the size of all panels.
Description
Fixes #11404
How Has This Been Tested?
A scale of 0.75 was applied in the MainLayout.razor to reproduce the bug then tested visually.
Visual testing for fixed width tabs:


Pre-fix:
Post fix:
Visual testing for variable width and vertical tabs:


Pre-fix:
Post fix:
Type of Changes
Checklist
dev
).