Skip to content

Conversation

versile2
Copy link
Contributor

Description

Re-enable Autocomplete OnAdornmentClick functionality

Regression

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 20, 2024
@onatsko
Copy link

onatsko commented Dec 20, 2024

thank you @versile2

@ScarletKuro
Copy link
Member

Would be nice to add a small test case to make sure the functionality doesn't get accidentally removed.

@versile2 versile2 force-pushed the fix/autocompleteadornmentclick branch from 1c5f032 to 428dea0 Compare December 21, 2024 16:59
@codecov
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (7fa1299) to head (428dea0).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10500      +/-   ##
==========================================
- Coverage   91.59%   91.58%   -0.01%     
==========================================
  Files         426      426              
  Lines       13283    13292       +9     
  Branches     2552     2557       +5     
==========================================
+ Hits        12166    12174       +8     
  Misses        546      546              
- Partials      571      572       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@versile2 versile2 changed the title Autocomplete Re-Enable OnAdornmentClick Autocomplete Re-Enable OnAdornmentClick and duplicated onfocus Dec 21, 2024
@versile2 versile2 changed the title Autocomplete Re-Enable OnAdornmentClick and duplicated onfocus Autocomplete Re-Enable OnAdornmentClick and Duplicated OnFocus Dec 21, 2024
@versile2 versile2 requested a review from ScarletKuro December 21, 2024 17:10
@ScarletKuro ScarletKuro changed the title Autocomplete Re-Enable OnAdornmentClick and Duplicated OnFocus MudAutocomplete: Fix OnAdornmentClick regression #10446 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudAutocomplete - don't work OnAdornmentClick event

3 participants