Release.yml: Update dist and docs automatically #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caio99BR
commented
Oct 2, 2025
Caio99BR
commented
- fixes Windows AArch64 Download failing for sccache v0.10.0 #189 after being triggered
- fixes docs and package.json consistently
crueter
pushed a commit
to Eden-CI/Workflow
that referenced
this pull request
Oct 8, 2025
* build.sh: Keep script consistency across platforms * add BUILDDIR across all scripts (ref: .ci/linux/package.sh) * call cmake from "source" to "build" not from build * extra parameters direct go direct on cmake (ref: .ci/windows/build.sh) Signed-off-by: Caio Oliveira <[email protected]> * [ci] check if Android Keys are set * this haunted me cause there's no name consistency Signed-off-by: Caio Oliveira <[email protected]> * [ci] enable sccache to reduce build time * should be changed to mozilla-actions/sccache-action (or cloned to Eden-CI) after they fix aarch64 download (the problem is, the fix is already on master, but it isn't released basically [dist is outdated]) See: * Mozilla-Actions/sccache-action#225 * Mozilla-Actions/sccache-action#189 Signed-off-by: Caio Oliveira <[email protected]> * [ci] android: enable gradle cache (android) + sccache (core) Signed-off-by: Caio Oliveira <[email protected]> * [ci] keep consistency across platforms and use CPM_CACHE_VERSION * keep the same name versioning of cache * clean solution to purge cache, since we can change varible internal without necessity of commit Signed-off-by: Caio Oliveira <[email protected]> * [ci] cache installation packages, should reduce 1m? Signed-off-by: Caio Oliveira <[email protected]> * [ci] Use parallel to improve building time Signed-off-by: Caio Oliveira <[email protected]> * [ci] Enable sccache globally * this explain why sccache is not working on android Signed-off-by: Caio Oliveira <[email protected]> * [ci] cleanup some cache things Signed-off-by: Caio Oliveira <[email protected]> * [ci] allow building with debug keys for PRs Signed-off-by: Caio Oliveira <[email protected]> * [ci] remove merged patch Signed-off-by: Caio Oliveira <[email protected]> * [ci] it's if not Signed-off-by: Caio Oliveira <[email protected]> --------- Signed-off-by: Caio Oliveira <[email protected]>
|
@sylvestre could you check it? |
|
how can i test this myself ? thanks :) |
Well it's just the update of dist/ folder but automatically:
And its's ready to use, currently im using: Without this, it's impossible to use on aarch64 builds (it fails cause the commit that fixes aarch64 is not present on dist/) |
|
Any update? |
sylvestre
reviewed
Nov 2, 2025
| id: get_version | ||
| run: | | ||
| git fetch --tags | ||
| latest_tag=$(git describe --tags --abbrev=0 || echo "v0.0.0") |
There was a problem hiding this comment.
Using '|| echo' to suppress commit errors could hide real issues, no ?
There was a problem hiding this comment.
also, why v0.0.0 as default ?
sylvestre
reviewed
Nov 2, 2025
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
There was a problem hiding this comment.
please add comment explain what it is doing
sylvestre
reviewed
Nov 2, 2025
Comment on lines
+1
to
+2
| # Copyright 2023 Mozilla Foundation | ||
| # |
There was a problem hiding this comment.
Suggested change
| # Copyright 2023 Mozilla Foundation | |
| # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.