IE8 fix #12
Closed
IE8 fix #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable, but not window.history.replaceState
|
Hi @daverodriguez! Sorry for not responding earlier. Can you please squash those commits, it makes it difficult to see what changes are being made. Also, it needs to be updated so I can automatically merge it. Thanks! |
Made test more specific to fix an IE8 bug where window.history is available, but not window.history.replaceState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! While regression testing we made a slight change to the window.history detection. IE<9 does have a window.history object, but it only contains the back(), forward() and go() methods, so now we're checking for window.history.replaceState specifically. The relevant line is line 25 of jquery.visualNav.js.