Update from_module to use the base module if it is a dependency #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBLMikeDemone
commented
Jul 14, 2025
...ots/test/only_generate_latest_versions/__snapshots__/onlyGenerateLatestVersions.spec.ts.snap
Show resolved
Hide resolved
|
Putting this back in draft while I iterate on it. The initial implementation didn't quite reflect what I intended, I'd like to make it so we only use the base module if we rely on the base module. Edit: Opened back up and updated the description |
SBLMikeDemone
changed the title
zachcampbellskyboxlabs
approved these changes
Jul 15, 2025
rlandav
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Parent modules (like
@minecraft/server-editor-bindings) are merged into base modules (like@minecraft/server-editor) but the native packages that take a dependency on types within the parent module still reference the base module which mean we can publish types or docs that rely on bindings modules which don't actually exist except internally.Solution
Change the metadata in the generator so that if a module depends on a base module, all references are updated from the parent module to the base module.