Skip to content

Fix: Make cleanTask synchronous #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Fix: Make cleanTask synchronous #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbb378a
Fix: Make cleanTask synchronous
Maescool Dec 9, 2024
9eb787d
Change files
Maescool Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tools/core-build-tasks/src/tasks/clean.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ export const DEFAULT_CLEAN_DIRECTORIES = ['temp', 'lib', 'dist'];
export function cleanTask(dirs: string[]) {
return () => {
for (const dir of dirs) {
console.log(`Cleaning ${dir}`);
rimraf(path.resolve(process.cwd(), dir), () => {
// no-op on unable to clean
});
try {
console.log(`Cleaning ${dir}`);
rimraf.sync(path.resolve(process.cwd(), dir));
} catch (_: unknown) {
// File or directory did not exist, so we no-op
}
}
};
}
Loading