Limit files generated when using custom schemes #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpsim I've added you for review to make sure this doesn't break normal schemes for you. I did a lot of testing, and everything seems good, but this was a tricky implementation. |
brentleyjones
commented
Aug 2, 2022
cgrindel
approved these changes
Aug 2, 2022
brentleyjones
force-pushed
the
bj/limit-files-generated-when-using-custom-schemes
branch
from
5a9f8d4 to
16c168e
Compare
brentleyjones
commented
Aug 2, 2022
brentleyjones
force-pushed
the
bj/limit-files-generated-when-using-custom-schemes
branch
3 times, most recently
from
452bbfc to
3adc334
Compare
Before this change `BazelDependencies` would generate files for all of the targets in a scheme, even when only a subset of targets were being built. Now we leverage the cached data in `XCBuildData` to gain insight into what targets are actually being built, allowing us to only build what is needed. Sadly this cached data doesn't say which exact target is being built as part of Index Build, so we still have to rely on our off-by-one logic there. Also of note, SwiftUI Previews build every target in a scheme, and this behavior is preserved with this method.
brentleyjones
force-pushed
the
bj/limit-files-generated-when-using-custom-schemes
branch
from
3adc334 to
e223e17
Compare
brentleyjones
deleted the
bj/limit-files-generated-when-using-custom-schemes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
BazelDependencieswould generate files for all of the targets in a scheme, even when only a subset of targets were being built. Now we leverage the cached data inXCBuildDatato gain insight into what targets are actually being built, allowing us to only build what is needed.Sadly this cached data doesn't say which exact target is being built as part of Index Build, so we still have to rely on our off-by-one logic there. Also of note, SwiftUI Previews build every target in a scheme, and this behavior is preserved with this method.