Generate all input files in BwX Index Build #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike in BwB mode, we don't get a nice "off-by-one" indicator of which targets Index Build has been attempted on in BwX mode. As a work around we are now building all generated inputs in BwX Index Build. This shouldn't be too bad in a normal project, but focused projects might include a lot of extra targets. Hopefully down the line we can find a better solution for both BwX and BwB.
brentleyjones
deleted the
bj/generate-all-input-files-in-bwx-index-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850.
Unlike in BwB mode, we don't get a nice "off-by-one" indicator of which targets Index Build has been attempted on in BwX mode. As a work around we are now building all generated inputs in BwX Index Build. This shouldn't be too bad in a normal project, but focused projects might include a lot of extra targets. Hopefully down the line we can find a better solution for both BwX and BwB.