Stop building dependencies of unfocused targets twice in BwX mode #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies of unfocused targets are now "islands". Their scheme will build them in whatever mode is being used for the project, but their dependencies will be built with Bazel. These targets also won't be set as dependencies of other targets, preventing them from being built twice in BwX mode.
brentleyjones
force-pushed
the
bj/stop-building-dependencies-of-unfocused-targets-twice-in-bwx-mode
branch
from
6c100b2 to
dbd71eb
Compare
cgrindel
approved these changes
Jul 25, 2022
brentleyjones
deleted the
bj/stop-building-dependencies-of-unfocused-targets-twice-in-bwx-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632.
Dependencies of unfocused targets are now "islands". Their scheme will build them in whatever mode is being used for the project, but their dependencies will be built with Bazel. These targets also won't be set as dependencies of other targets, preventing them from being built twice in BwX mode.