Skip to content

Suppress autogenerated schemes that conflict with custom scheme names #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 24, 2022
Merged

Suppress autogenerated schemes that conflict with custom scheme names #809

merged 12 commits into from
Jul 24, 2022

Conversation

cgrindel
Copy link
Contributor

Related to #573.

@cgrindel cgrindel requested a review from brentleyjones July 23, 2022 23:54
@cgrindel cgrindel self-assigned this Jul 23, 2022
@cgrindel cgrindel mentioned this pull request Jul 23, 2022
Closed
37 tasks
brentleyjones
brentleyjones approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename back the generator custom scheme so the fixtures show this off?

@cgrindel cgrindel force-pushed the cg/gh573_prevent_scheme_name_collisions branch 2 times, most recently from 84051f6 to 8f9abfa Compare July 24, 2022 03:17
@cgrindel cgrindel changed the base branch from main to cg/fix_sort_issue July 24, 2022 03:18
brentleyjones
brentleyjones reviewed Jul 24, 2022
View reviewed changes
@cgrindel cgrindel mentioned this pull request Jul 24, 2022
Merged
@brentleyjones
Copy link
Contributor

brentleyjones commented Jul 24, 2022 •
edited
Loading

Can you update the fixtures as well?

Edit: I assume you did actually, but because of case sensitivity issues it's keeping the old Generator case. I think there are some magic incantations on Stackoverflow to get it to pickup the filename change.

Base automatically changed from cg/fix_sort_issue to main July 24, 2022 13:42
@cgrindel cgrindel force-pushed the cg/gh573_prevent_scheme_name_collisions branch from 2742547 to d6f6087 Compare July 24, 2022 13:52
@cgrindel
Copy link
Contributor Author

I think that I have the filename case issue resolved. I am seeing it with the original lowercase name.

@cgrindel cgrindel enabled auto-merge (squash) July 24, 2022 13:54
@cgrindel cgrindel merged commit d645c67 into main Jul 24, 2022
@cgrindel cgrindel deleted the cg/gh573_prevent_scheme_name_collisions branch July 24, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrindel @brentleyjones