-
Notifications
You must be signed in to change notification settings - Fork 106
Create custom Xcode schemes #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e66d02
to
0e1e5c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are creating custom schemes, shouldn't the ones for Generator have changed?
@brentleyjones You are correct. I will investigate before merging this PR. |
The For this PR, I will rename the custom scheme to not conflict. I have added two tasks to #573.
|
0e1e5c2
to
452fc83
Compare
I verified that the custom scheme is written (Good catch, @brentleyjones). I launched the scheme in Xcode and was able to build and test it successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is conflicting schemes, can we have the custom ones just override the automatic one? Seems better than an error, since one controls the name of the custom scheme.
(Would require changing the order that they are made in, but I think that's for the best. Or the automatic ones can get a list of custom ones made and not make ones from it, etc.) |
Sure. I was going to add code that checks an autogenerated scheme name and add a prefix (e.g., |
I like skipping the autogenerated one. Then one can use |
Related to #573.
XcodeScheme
structs.XcodeScheme.ProfileAction
.shouldCreateScheme
filter tocreateAutogeneratedXCSchemes
. It was in the shared code.targetResolver(referencedContainer:)
toFixtures
.