Fix simple BwX projects with unfocused targets #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now correctly include the `BazelDependencies` target. This isn't perfect, there is still situations which we should include `BazelDependencies` but we aren't, but they can be addressed with further Focused Projects work.
BalestraPatrick
approved these changes
Jul 15, 2022
brentleyjones
deleted the
bj/fix-simple-bwx-projects-with-unfocused-targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705.
We now correctly include the
BazelDependenciestarget.This isn't perfect, there is still situations which we should include
BazelDependenciesbut we aren't, but they can be addressed with further Focused Projects work.