Add App Clip example #732
Merged
Add App Clip example #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
commented
Jul 13, 2022
Comment on lines
+5
to
+6
| <key>application-identifier</key> | ||
| <string>TEAMID.APP_CLIP_BUNDLE_ID</string> |
There was a problem hiding this comment.
Having to set this for BwB, but not BwX, continues to stump me. Ideally rules_apple would handle that, but then you would have to know info from your parent app, which is tricky. Maybe even just failing to build if it's not defined...
There was a problem hiding this comment.
+1 to this. We have a macro/rule that works around this annoying issue.
There was a problem hiding this comment.
brentleyjones
force-pushed
the
bj/add-app-clip-example
branch
from
4e85986 to
64d2245
Compare
brentleyjones
force-pushed
the
bj/add-app-clip-example
branch
2 times, most recently
from
eef9868 to
cdd728a
Compare
brentleyjones
force-pushed
the
bj/add-app-clip-example
branch
from
cdd728a to
006db3d
Compare
BalestraPatrick
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79.