Skip to content

Conversation

luispadron
Copy link
Contributor

@luispadron luispadron commented Jul 8, 2022

Summary

Add support for both BwB and BwX for the launchdplists rules_apple attribute.

The launchdplists property takes a list of .plist labels which are then merged by rules_apple into a single .plist. This .plist is then embedded into the macos_command_line_application binary.

rules_apple embeds the launchd plist into the __TEXT section of the binary under the section __launchd_plist (see here)

Closes #99

Tasks

  • Add tests
  • Update documentation

@luispadron luispadron force-pushed the lpadron/support-laundplists branch from 2610d79 to d086bdb Compare July 8, 2022 13:08
@brentleyjones brentleyjones changed the title Support launchdplists Add support for launchdplists Jul 8, 2022
@luispadron luispadron force-pushed the lpadron/support-laundplists branch from d086bdb to 152ee39 Compare July 8, 2022 13:56
@luispadron luispadron force-pushed the lpadron/support-laundplists branch from 6b7101f to 2e93ed9 Compare July 8, 2022 14:28
@luispadron luispadron marked this pull request as ready for review July 8, 2022 14:28
@luispadron luispadron force-pushed the lpadron/support-laundplists branch 2 times, most recently from 5b5abe3 to 85e4732 Compare July 8, 2022 14:41
@luispadron
Copy link
Contributor Author

@brentleyjones Think this is probably ready for a proper review now 🚀

Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! ❤️

Add support for both BwB and BwX for the `launchdplists` rules_apple attribute.
@luispadron luispadron force-pushed the lpadron/support-laundplists branch from 85e4732 to 0e3ea81 Compare July 8, 2022 14:47
@brentleyjones brentleyjones enabled auto-merge (squash) July 8, 2022 14:54
@brentleyjones brentleyjones disabled auto-merge July 8, 2022 14:54
@brentleyjones brentleyjones enabled auto-merge (squash) July 8, 2022 14:54
@brentleyjones brentleyjones merged commit f1efae5 into MobileNativeFoundation:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support macos_command_line_application
2 participants