Apply compiler options the same as Bazel #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No longer set C related flags for Swift targets, as they aren't used and are instead passed to `OTHER_SWIFT_FLAGS` with `-Xcc` prefixes - Set Swift PCM flags exactly as rules_swift does - Correctly retrieve copts for `objc_library` targets by checking for `ObjcProvider` and changing the action that is queried based on that (this check will have to change once `ObjcProvider` is removed) - Only set objc based flags for objc based actions - Stop uniquing flags, as Bazel doesn't either
brentleyjones
force-pushed
the
bj/apply-compiler-options-the-same-as-bazel
branch
from
ab9f0b1 to
9c73268
Compare
BalestraPatrick
approved these changes
Jun 27, 2022
maxwellE
reviewed
Jun 27, 2022
| return base_pcm_flags + pcm_defines | ||
|
|
||
| # Lifted from rules_swift, to mimic its behavior | ||
| def _swift_command_line_objc_copts(*, compilation_mode, objc_fragment): |
There was a problem hiding this comment.
I kinda thought to do this but it seemed strange to rip it out, looks like there is really no other way though to make sure we have parity
| "-fstack-protector-all", | ||
| "-g", |
There was a problem hiding this comment.
Yes. Its only filtered from the Swift PCM side. It's actually set on the Obj-C compiling side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #586. Part of #415.
OTHER_SWIFT_FLAGSwith-Xccprefixesobjc_librarytargets by checking forObjcProviderand changing the action that is queried based on that (this check will have to change onceObjcProvideris removed)