Support codesignopts
#593
Merged
Support codesignopts
#593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellE
force-pushed
the
me/support_codesignopts
branch
from
6a5a65e to
a08e52d
Compare
maxwellE
force-pushed
the
me/support_codesignopts
branch
from
306d6e7 to
235bdf2
Compare
maxwellE
commented
Jun 28, 2022
Comment on lines
54
to
59
| bundle_id = None | ||
| codesignopts = None | ||
| entitlements = None | ||
| hdrs = () | ||
| infoplists = () | ||
| non_arc_srcs = () | ||
| pch = None |
maxwellE
commented
Jun 28, 2022
| @@ -88,6 +89,10 @@ def _default_automatic_target_processing_aspect_impl(target, ctx): | |||
| infoplists = ("infoplists") | |||
| should_generate_target = False | |||
| elif AppleBundleInfo in target: | |||
| codesignopts = "codesignopts" | |||
There was a problem hiding this comment.
Sorted these values in both locations
xcodeproj/internal/default_automatic_target_processing_aspect.bzl
Outdated
Show resolved
Hide resolved
xcodeproj/internal/default_automatic_target_processing_aspect.bzl
Outdated
Show resolved
Hide resolved
brentleyjones
approved these changes
Jun 28, 2022
xcodeproj/internal/default_automatic_target_processing_aspect.bzl
Outdated
Show resolved
Hide resolved
Adds logic to support the `codesignopts` property on rules as part of Support `macos_command_line_application` MobileNativeFoundation#99
Co-authored-by: Brentley Jones <[email protected]>
Use `XcodeProjAutomaticTargetProcessingInfo` to fetch codesign flags
Co-authored-by: Brentley Jones <[email protected]>
maxwellE
force-pushed
the
me/support_codesignopts
branch
from
ac68499 to
1b53f8e
Compare
This was referenced Jun 28, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to support the
codesignoptsproperty on rulesas part of Support
macos_command_line_application#99