Only build BazelDependencies once in a build
#534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies a different fix that 55142f5 tried to accomplish. Before adding consolidated targets the previous fix worked fine, though it did have potential cache issues with the PATH being different for different platforms. With consolidated targets there were builds where multiple `BazelDependencies` would be in a single build, particularly during indexing.
BalestraPatrick
approved these changes
Jun 12, 2022
brentleyjones
deleted the
bj/only-build-bazeldependencies-once-in-a-build
branch
|
Seems this causes issues for non multi-platform builds. Looking for a proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a different fix that 55142f5 tried to accomplish. Before adding consolidated targets the previous fix worked fine, though it did have potential cache issues with the PATH being different for different platforms.
With consolidated targets there were builds where multiple
BazelDependencieswould be in a single build, particularly during indexing.