Fix ENABLE_PREVIEWS setting in BazelDependencies
#512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set `SWIFT_OPTIMIZATION_LEVEL = -Onone`, otherwise `ENABLE_PREVIEWS` is always `NO`, even when building for previews.
| @@ -50,6 +50,8 @@ $(INDEXING_DEPLOYMENT_LOCATION__) | |||
| "INTERNAL_DIR": """ | |||
| $(PROJECT_FILE_PATH)/\(filePathResolver.internalDirectoryName) | |||
| """, | |||
| // Needed as the default otherwise `ENABLE_PREIVEWS` isn't set | |||
There was a problem hiding this comment.
Nit: small typo in the docs
BalestraPatrick
approved these changes
Jun 7, 2022
brentleyjones
deleted the
bj/fix-enable_previews-setting-in-bazeldependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set
SWIFT_OPTIMIZATION_LEVEL = -Onone, otherwiseENABLE_PREVIEWSis alwaysNO, even when building for previews.