Group sub-consolidations #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if you have minimum OS differences in your tree, and environment differences, you would get 3 consolidated targets instead of two (one proper consolidation and then 2 non-consolidated target). Now the consolidation tries to group like targets together more. Things can still get odd if you somehow have unique configurations of a target, as this just performs a simple sort and bucket for now.
BalestraPatrick
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if you have minimum OS differences in your tree, and environment differences, you would get 3 consolidated targets instead of two (one proper consolidation and then 2 non-consolidated target). Now the consolidation tries to group like targets together more. Things can still get odd if you somehow have unique configurations of a target, as this just performs a simple sort and bucket for now.