Consolidate targets #498
Merged
Consolidate targets #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
commented
Jun 2, 2022
jpsim
approved these changes
Jun 3, 2022
brentleyjones
force-pushed
the
bj/consolidate-targets
branch
from
8fe8f71 to
585f5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #285.
Sorry for the large PR, I don't think I can break it apart much more. I broke apart some of the changes into refactor commits, to make it slightly easier to review. The large primary commit is mainly just piping
ConsolidatedTargetthrough the system, with the behavior changes being inGenerator.disambiguateTargets()andGenerator.setTargetConfigurations(). The behavior changes have added tests.