Skip to content

Filter out non-header files from Compile Source phase #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2022
Merged

Filter out non-header files from Compile Source phase #469

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d407617
Filters out non-header files from publicHeaders
maxwellE May 24, 2022
3ce6a18
filter non arc sources as well
maxwellE May 24, 2022
6a347ca
feedback
maxwellE May 24, 2022
56815d2
syntax
maxwellE May 24, 2022
af577ad
fixtures & feedback
maxwellE May 24, 2022
a612e0b
fix fixtures
maxwellE May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/generator/src/Generator+AddTargets.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ File "\(headerFile.filePath)" not found in `files`
.forcedBazelCompileFiles(buildMode: buildMode)
let sources = forcedBazelCompileFiles.map(SourceFile.init) +
inputs.srcs.map(SourceFile.init) +
inputs.nonArcSrcs.map { filePath in
inputs.nonArcSrcs
.filter { !$0.path.isHeader }
.map { filePath in
return SourceFile(
filePath,
compilerFlags: ["-fno-objc-arc"]
Expand Down