Skip to content

Change pbxTargets type to be [TargetID: PBXTarget] #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 4, 2022
Merged

Change pbxTargets type to be [TargetID: PBXTarget] #397

merged 9 commits into from
May 4, 2022

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented May 4, 2022 •
edited
Loading

Related to #101.

  • Add nativeTarget function to Dictionary instances with value of type PBXTarget. Returns the instance as a PBXNativeTarget if it is found.
  • Update function signatures to use the new type.
  • Remove unused FilePathResolver argument from addTargets.

@cgrindel cgrindel requested a review from brentleyjones May 4, 2022 14:48
@cgrindel cgrindel self-assigned this May 4, 2022
@cgrindel cgrindel enabled auto-merge (squash) May 4, 2022 14:48
@cgrindel cgrindel disabled auto-merge May 4, 2022 14:50
@cgrindel cgrindel enabled auto-merge (squash) May 4, 2022 14:50
brentleyjones
brentleyjones reviewed May 4, 2022
View reviewed changes
@cgrindel cgrindel requested a review from brentleyjones May 4, 2022 14:56
@cgrindel cgrindel merged commit 9142b8f into main May 4, 2022
@cgrindel cgrindel deleted the cg/gh101_refactor_pbxtargets branch May 4, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrindel @brentleyjones