Skip to content

Fix build log parsing for 'fatal error:' diagnostics #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amorde
Copy link
Contributor

@amorde amorde commented Jun 24, 2025

Fixes #3203

Demo

Before:

Screenshot 2025-06-24 at 3 38 26 PM

After:

Screenshot 2025-06-24 at 4 09 42 PM

@amorde amorde requested a review from a team as a code owner June 24, 2025 23:24
Copy link

@dnkoutso dnkoutso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@brentleyjones
Copy link
Contributor

Need to sign your git commit for DCO check.

@amorde amorde force-pushed the fatal-error-processing branch from c35e87b to 1573ee0 Compare June 26, 2025 01:46
@brentleyjones brentleyjones merged commit c08dd99 into MobileNativeFoundation:main Jun 26, 2025
10 of 11 checks passed
@brentleyjones
Copy link
Contributor

Small optimization: #3208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Certain compilation errors are not parsed properly by process_bazel_build_log.py
5 participants