Set define with GCC_PREPROCESSOR_DEFINITIONS instead of OTHER_CFLAGS
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to properly support PCM creation. We also had to set `OTHER_SWIFT_FLAGS` of the remaining `OTHER_CFLAGS` (with `-Xcc`) to pass through `cc_toolchain` set flags. This fixes the "redefining builtin macro" warning.
brentleyjones
force-pushed
the
bj/set-GCC_PREPROCESSOR_DEFINITIONS
branch
from
f6db282 to
62e4b40
Compare
BalestraPatrick
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #94.
This is needed to properly support implicit PCM compilation.
We also had to set
OTHER_SWIFT_FLAGSof the remainingOTHER_CFLAGS(with-Xcc) to pass throughcc_toolchainset flags. This fixes the "redefining builtin macro" warning.