Skip to content

Conversation

@zicsus
Copy link
Collaborator

@zicsus zicsus commented Apr 14, 2021

What does this PR do?
Changes webpack devtool to more performant cheap-source-map. This will help speed up compilation a bit although we should consider giving user an option to add custom webpack config. Lower config systems should benefit from this.

Where to start reviewing?
gulpfile.js

Related Issues?
n/a

Caveats?
n/a

Reviewers?
@nkrusch

@nkrusch
Copy link
Contributor

nkrusch commented Apr 14, 2021

@zicsus unrelated to this PR but about source maps in general:

I noticed there is no way to disable source maps for prod builds. I think this should be an option, because it reduces extension size and obfuscation reasons. What are your thoughts?

@nkrusch nkrusch added this to the 1.0.3 milestone Apr 14, 2021
@nkrusch nkrusch merged commit b359804 into MobileFirstLLC:master Apr 14, 2021
@zicsus
Copy link
Collaborator Author

zicsus commented Apr 14, 2021

@nkrusch is it generating source maps in production build?
We are setting mode properly so not sure why it's doing that. I've to take a look.

@nkrusch
Copy link
Contributor

nkrusch commented Apr 14, 2021

Yes. I tried latest and double checked; I'm seeing this behavior.

@zicsus
Copy link
Collaborator Author

zicsus commented Apr 15, 2021

Yeah! It is doing that. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants