Skip to content

Conversation

benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Feb 5, 2025

GEOPY-1963 - Convert all DC/IP 3D/2D params to BaseData

@github-actions github-actions bot changed the title Geopy 1963 GEOPY-1963: Convert all DC/IP 3D/2D params to BaseData Feb 5, 2025
domfournier
domfournier previously approved these changes Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 97.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (90ec6c2) to head (411c3fa).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/electricals/params.py 85.18% 2 Missing and 2 partials ⚠️
...s/direct_current/pseudo_three_dimensions/params.py 97.36% 1 Missing ⚠️
simpeg_drivers/electricals/driver.py 90.00% 0 Missing and 1 partial ⚠️
...ced_polarization/pseudo_three_dimensions/params.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #139      +/-   ##
===========================================
- Coverage    90.12%   88.55%   -1.58%     
===========================================
  Files           92       92              
  Lines         4782     4813      +31     
  Branches       569      571       +2     
===========================================
- Hits          4310     4262      -48     
- Misses         341      419      +78     
- Partials       131      132       +1     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 95.65% <100.00%> (ø)
simpeg_drivers/electricals/__init__.py 100.00% <100.00%> (ø)
...s/direct_current/pseudo_three_dimensions/driver.py 100.00% <100.00%> (ø)
...ricals/direct_current/three_dimensions/__init__.py 100.00% <100.00%> (ø)
...ctricals/direct_current/three_dimensions/driver.py 100.00% <100.00%> (ø)
...ctricals/direct_current/three_dimensions/params.py 100.00% <100.00%> (ø)
...ctricals/direct_current/two_dimensions/__init__.py 100.00% <100.00%> (ø)
...lectricals/direct_current/two_dimensions/driver.py 100.00% <100.00%> (ø)
...lectricals/direct_current/two_dimensions/params.py 100.00% <100.00%> (ø)
...ced_polarization/pseudo_three_dimensions/driver.py 100.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

@domfournier domfournier merged commit c539f7e into develop Feb 7, 2025
11 checks passed
@domfournier domfournier deleted the GEOPY-1963 branch February 7, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants