Skip to content

Conversation

domfournier
Copy link
Collaborator

@domfournier domfournier commented Nov 8, 2024

GEOPY-760 - Create spatial tiling estimator

@github-actions github-actions bot changed the title GEOPY-760 GEOPY-760: Create spatial tiling estimator Nov 8, 2024
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	pyproject.toml
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, but I couldn't quite decipher what was going on in a few places. I have some suggestions to update docstring and refactor for readability and unit testing. Also let's try to re-use the BaseDriver class.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 93.25153% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (83d7d10) to head (a842928).
Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/utils/tile_estimate.py 91.26% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    91.55%   91.59%   +0.03%     
===========================================
  Files           88       89       +1     
  Lines         5105     5235     +130     
  Branches       537      549      +12     
===========================================
+ Hits          4674     4795     +121     
- Misses         309      312       +3     
- Partials       122      128       +6     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 92.20% <100.00%> (-0.15%) ⬇️
...peg_drivers/components/factories/misfit_factory.py 97.05% <100.00%> (+0.33%) ⬆️
simpeg_drivers/components/meshes.py 88.23% <ø> (-0.34%) ⬇️
simpeg_drivers/joint/driver.py 90.56% <100.00%> (-0.67%) ⬇️
simpeg_drivers/utils/utils.py 70.05% <100.00%> (+1.73%) ⬆️
simpeg_drivers/utils/tile_estimate.py 91.26% <91.26%> (ø)

benk-mira
benk-mira previously approved these changes Nov 13, 2024
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@benk-mira
Copy link
Contributor

Can we support Python Plugin Groups?
image

@benk-mira
Copy link
Contributor

Any way to edit the options of the original SimPEG group instead of copying and editing the n_tiles option?
image

@benk-mira
Copy link
Contributor

Let's format those floats for readability and describe the units. Something like "Computed tile sizes (Gb) per number of tile."
image

@benk-mira
Copy link
Contributor

Would be cool to format that dictionary in a table. Check this package:
https://pypi.org/project/tabulate/

@domfournier
Copy link
Collaborator Author

Can we support Python Plugin Groups?

Nope, needs to a SimpegGroup.

@domfournier domfournier merged commit 025d7c9 into develop Nov 14, 2024
11 checks passed
@domfournier domfournier deleted the GEOPY-760 branch November 14, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants