-
Notifications
You must be signed in to change notification settings - Fork 2
GEOPY-760: Create spatial tiling estimator #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool, but I couldn't quite decipher what was going on in a few places. I have some suggestions to update docstring and refactor for readability and unit testing. Also let's try to re-use the BaseDriver class.
# Conflicts: # pyproject.toml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #101 +/- ##
===========================================
+ Coverage 91.55% 91.59% +0.03%
===========================================
Files 88 89 +1
Lines 5105 5235 +130
Branches 537 549 +12
===========================================
+ Hits 4674 4795 +121
- Misses 309 312 +3
- Partials 122 128 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Would be cool to format that dictionary in a table. Check this package: |
Nope, needs to a SimpegGroup. |
GEOPY-760 - Create spatial tiling estimator