Skip to content

Conversation

stephantul
Copy link
Member

@stephantul stephantul commented Feb 26, 2025

#199 shows that it is confusing that out_dim comes before the model_name in from_pretrained. So fix this, I switched to only allowing named arguments in from_pretrained. I explicitly did not change it in the other parts of the code base because confusion is less apparent there.

@stephantul stephantul changed the title Named args in pretrain fix: only allows named args in pretrain Feb 26, 2025
@stephantul stephantul requested a review from Pringled February 26, 2025 10:49
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/train/base.py 100.00% <100.00%> (ø)
tests/test_trainable.py 100.00% <100.00%> (ø)

@stephantul stephantul merged commit 0581046 into main Feb 26, 2025
6 checks passed
@stephantul stephantul deleted the named-args-in-pretrain branch February 26, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants