Skip to content

feat: add support for pattern for unused tokens. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

stephantul
Copy link
Member

No description provided.

@stephantul stephantul changed the title Fix tokenizer issue feat: add support for pattern for unused tokens. Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/distill/tokenizer.py 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/distill/distillation.py 96.66% <100.00%> (+0.40%) ⬆️
model2vec/utils.py 92.00% <100.00%> (+0.51%) ⬆️
tests/test_distillation.py 91.76% <100.00%> (+1.76%) ⬆️
model2vec/distill/tokenizer.py 75.86% <0.00%> (+2.64%) ⬆️

@stephantul stephantul requested a review from Pringled December 22, 2024 17:24
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicenice

@stephantul stephantul merged commit 453527f into main Dec 23, 2024
5 of 6 checks passed
@stephantul stephantul deleted the fix_issue_with_tokenizer branch December 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants