feat(review): fallback to local eval with expired artifacts #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
approved these changes
Aug 3, 2025
|
If we just want a better message, this is what it looks like atm. -> Fetching eval results from GitHub actions
https://github.com/NixOS/nixpkgs/pull/391575 failed to build:
GitHub artifact 3034442382 has expired or been removed
* "try passing --eval local"
* "try re-running GitHub CI" |
Signed-off-by: Austin Horstman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a custom exception when we a get 410 on fetching CI results and handle accordingly in the review process to fallback to local evaluation.
Closes #476
Dependent on #545 for CI, pulled these changes into separate branch so it doesn't hold that one up.
Just saw this in the associated issue
Should i make the exception raised on
404, as well? My understanding was that 404 waits for a retry loop so that you can wait for an evaluation to finish. But, here we had an evaluation that did finish and we know it won't because it just expired so we just force a local retry.