Skip to content

feat: Fix --override-filename for flakes #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2024
+5 −3
Merged

feat: Fix --override-filename for flakes #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions nix_update/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ def __post_init__(
self.version_position = None
else:
self.version_position = Position(**raw_version_position)
if self.filename:
self.version_position.file = self.filename

if raw_cargo_lock is None:
self.cargo_lock = NoCargoLock()
Expand Down Expand Up @@ -221,11 +223,11 @@ def eval_attr(opts: Options) -> Package:
] + opts.extra_flags
res = run(cmd)
out = json.loads(res.stdout)
package = Package(attribute=opts.attribute, import_path=opts.import_path, **out)
if opts.override_filename is not None:
package.filename = opts.override_filename
out["filename"] = opts.override_filename
if opts.url is not None:
package.parsed_url = urlparse(opts.url)
out["url"] = opts.url
package = Package(attribute=opts.attribute, import_path=opts.import_path, **out)
if opts.version_preference != VersionPreference.SKIP and package.old_version == "":
raise UpdateError(
f"Nix's builtins.parseDrvName could not parse the version from {package.name}"
Expand Down