fix updating importCargoLock when lockFile is in the nix store
#148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for my nushell+wezterm derivations pointed at my fork. Thank you very much! |
Mic92
reviewed
Apr 3, 2023
Mic92
reviewed
Apr 3, 2023
Comment on lines
+84
to
+85
| elif raw_cargo_lock is False: | ||
| self.cargo_lock = CargoLockInStore() |
Owner
There was a problem hiding this comment.
I am unsure about this part. If we get false, do we want to throw an error instead?
Collaborator
Author
There was a problem hiding this comment.
this is false when it is a store path in a flake, so I would say the current solution is good
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Collaborator
Author
|
bors merge |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #147