Skip to content
This repository was archived by the owner on Feb 27, 2020. It is now read-only.

Conversation

@br1-msw
Copy link
Contributor

@br1-msw br1-msw commented Jan 12, 2018

@rkd-msw please sanity check that these are sensible checks. I don't think there are other sproutlets we can hit this on.

@br1-msw br1-msw requested a review from rkday-pro January 12, 2018 15:09
@rkday-pro
Copy link
Contributor

Looks good as far as it goes. But:

rkd@ip-10-0-0-85:~/sprout$ grep -r PJSIP_SC_INTERNAL_SERVER_ERROR src
src/bgcfsproutlet.cpp:        pjsip_msg* rsp = create_response(req, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/subscriptionsproutlet.cpp:    st_code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/hss_sip_mapping.cpp:        st_code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/thread_dispatcher.cpp:              reject_with_retry_header(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/basicproxy.cpp:    reject_request(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/basicproxy.cpp:    reject_request(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/basicproxy.cpp:      status_code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/basicproxy.cpp:    pjsip_tsx_terminate(_tsx, PJSIP_SC_INTERNAL_SERVER_ERROR);//LCOV_EXCL_LINE
src/authenticationsproutlet.cpp:      rsp->line.status.code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/authenticationsproutlet.cpp:      rsp->line.status.reason = *pjsip_get_status_text(PJSIP_SC_INTERNAL_SERVER_ERROR);
src/registrarsproutlet.cpp:    st_code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/registrarsproutlet.cpp:    rsp->line.status.code = PJSIP_SC_INTERNAL_SERVER_ERROR;
src/mmtel.cpp:  case PJSIP_SC_INTERNAL_SERVER_ERROR:
src/bono.cpp:    reject_request(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/bono.cpp:    reject_request(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/bono.cpp:    reject_request(rdata, PJSIP_SC_INTERNAL_SERVER_ERROR);
src/bono.cpp:      return PJSIP_SC_INTERNAL_SERVER_ERROR; // LCOV_EXCL_LINE find_create_flow failure cases are all excluded already
src/bono.cpp:    send_response(PJSIP_SC_INTERNAL_SERVER_ERROR);
src/bono.cpp:    pjsip_tsx_terminate(_tsx, PJSIP_SC_INTERNAL_SERVER_ERROR);

Think the bgcfsproutlet.cpp, hss_sip_mapping.cpp and maybe basicproxy.cpp are worth looking at if you haven't already.

@br1-msw
Copy link
Contributor Author

br1-msw commented Jan 12, 2018

hss_sip_mapping/basicproxy already has a TRC_ERROR logs, and bgcfsproutlet TRC_WARNING so should already come out.

@br1-msw br1-msw merged commit d14c2fa into apple_scrumble Jan 12, 2018
@br1-msw br1-msw deleted the 500logs branch January 12, 2018 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants