-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Fix CocoaPods install on Linux #9545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
This is only been tested on As the CI job is already setting up qemu, it should be straightforward to have the image built and tested on |
062fbcb to
350d29c
Compare
350d29c to
d4c29f8
Compare
41c22be to
2d68073
Compare
1be75ce to
00e0295
Compare
9b81111 to
f10a01a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dee274b to
d7bd392
Compare
|
0904796 to
894d5ef
Compare
894d5ef to
18be449
Compare
ensures that any patches to packages used in these steps are effective
18be449 to
fd63d27
Compare
Cal-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|




Description
Fixes and enables CocoaPods installation on Linux. After this change, macOS is not required to update
Podfile.lock.pod installstep inyarn setupscript on all platforms, not just macOSreact-nativepatch that resolves installation error due to attempt at patching missing XcodeDockerfilewhich can be used locally to run routine development tasks likeyarn setup.Related issues
Manual testing steps
scripts/docker/README.mdto build and run docker imageyarn setupScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist