Skip to content

Conversation

@tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 6, 2025

Description

Re-order migrations 105, 106, 107

Removal of migration 104 redux-persist slicing. No longer needed

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Reorders and repurposes migrations (104–106), removes 107, updates inflation/deflation thresholds, and aligns tests with the new behaviors.

  • Migrations:
    • 104: Simplified to only reset PhishingController.urlScanCache; adds error reporting for invalid state.
    • 105: Now removes RatesController from engine.backgroundState; no-ops if absent; standardized error handling.
    • 106: Now cleans PPOM MMKV storage (PPOMDB); logic moved from former 107; returns unchanged state; error captured.
    • Removed: 107 migration and its tests.
    • Index (migrations/index.ts): Dropped 107 from migrationList; changed inflate trigger to > 106 and deflate on last version >= 106.
  • Tests:
    • Updated/added tests for 104–106 reflecting new responsibilities and error messages.
    • Adjusted async migration flow tests to new version thresholds; removed old 107 tests; renamed for concision.

Written by Cursor Bugbot for commit a52e123. This will update automatically on new commits. Configure here.

@tommasini tommasini requested a review from a team as a code owner November 6, 2025 19:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Nov 6, 2025
@tommasini tommasini changed the title fix: re order migrations 105, 106, 107 fix: re order migrations 105, 106, 107 cp-7.59.0 Nov 6, 2025
@github-actions github-actions bot added size-L and removed size-XL labels Nov 6, 2025
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MarioAslau
MarioAslau previously approved these changes Nov 6, 2025
@tommasini tommasini enabled auto-merge November 6, 2025 20:13
@MarioAslau MarioAslau added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Nov 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@tommasini tommasini added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 2a5d2de Nov 7, 2025
148 of 150 checks passed
@tommasini tommasini deleted the fix/re-order-migrations branch November 7, 2025 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-L team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants