Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';

interface SelectedAsset {
isETH: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { selectInternalAccounts } from '../../../selectors/accountsController';
import Cell, {
CellVariant,
} from '../../../component-library/components/Cells/Cell';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { useStyles } from '../../../component-library/hooks';
import { TextColor } from '../../../component-library/components/Texts/Text';
import SensitiveText, {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import {
TotalFiatBalancesCrossChains,
useGetTotalFiatBalanceCrossChains,
} from '../../../../hooks/useGetTotalFiatBalanceCrossChains';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { getChainIdsToPoll } from '../../../../../selectors/tokensController';
import AggregatedPercentageCrossChains from '../../../../../component-library/components-temp/Price/AggregatedPercentage/AggregatedPercentageCrossChains';

Expand Down
6 changes: 4 additions & 2 deletions app/components/Views/AccountActions/AccountActions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useDispatch, useSelector } from 'react-redux';
import Share from 'react-native-share';

// External dependencies
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import BottomSheet, {
BottomSheetRef,
} from '../../../component-library/components/BottomSheets/BottomSheet';
Expand Down Expand Up @@ -397,7 +397,9 @@ const AccountActions = () => {
actionTitle={strings('accounts.remove_hardware_account')}
iconName={IconName.Close}
onPress={showRemoveHWAlert}
testID={AccountActionsBottomSheetSelectorsIDs.REMOVE_HARDWARE_ACCOUNT}
testID={
AccountActionsBottomSheetSelectorsIDs.REMOVE_HARDWARE_ACCOUNT
}
/>
)}
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { useMetrics } from '../../../components/hooks/useMetrics';

///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
import { CaipChainId } from '@metamask/utils';
import { KeyringClient } from '@metamask/keyring-api';
import { KeyringClient } from '@metamask/keyring-snap-client';
import { BitcoinWalletSnapSender } from '../../../core/SnapKeyring/BitcoinWalletSnap';
import { MultichainNetworks } from '../../../core/Multichain/constants';
import { useSelector } from 'react-redux';
Expand Down
2 changes: 1 addition & 1 deletion app/components/Views/EditAccountName/EditAccountName.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { useSelector } from 'react-redux';
import { SafeAreaView } from 'react-native';

// External dependencies
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import Text from '../../../component-library/components/Texts/Text/Text';
import { View } from 'react-native-animatable';
import { TextVariant } from '../../../component-library/components/Texts/Text';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from 'react-native';
import { useDispatch, useSelector } from 'react-redux';
import { wordlist } from '@metamask/scure-bip39/dist/wordlists/english';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import QRCode from 'react-native-qrcode-svg';
import { RouteProp, ParamListBase } from '@react-navigation/native';
import ScrollableTabView, {
Expand Down
18 changes: 11 additions & 7 deletions app/components/Views/RevealPrivateCredential/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ import React from 'react';
import { render, fireEvent, waitFor } from '@testing-library/react-native';
import configureMockStore from 'redux-mock-store';
import { Provider } from 'react-redux';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { backgroundState } from '../../../util/test/initial-root-state';
import { RevealPrivateCredential } from './';
import { ThemeContext, mockTheme } from '../../../util/theme';
import { RevealSeedViewSelectorsIDs } from '../../../../e2e/selectors/Settings/SecurityAndPrivacy/RevealSeedView.selectors';
import { EthAccountType, EthMethod, EthScopes } from '@metamask/keyring-api';
import { KeyringTypes } from '@metamask/keyring-controller';

jest.mock('react-redux', () => ({
...jest.requireActual('react-redux'),
Expand Down Expand Up @@ -147,24 +149,26 @@ describe('RevealPrivateCredential', () => {

it('renders with a custom selectedAddress', async () => {
const mockInternalAccount: InternalAccount = {
type: 'eip155:eoa',
type: EthAccountType.Eoa,
id: 'unique-account-id-1',
address: '0x1234567890123456789012345678901234567890',
options: {
someOption: 'optionValue',
anotherOption: 42,
},
scopes: [EthScopes.Namespace],
methods: [
'personal_sign',
'eth_sign',
'eth_signTransaction',
'eth_sendTransaction',
EthMethod.PersonalSign,
EthMethod.SignTransaction,
EthMethod.SignTypedDataV1,
EthMethod.SignTypedDataV3,
EthMethod.SignTypedDataV4,
],
metadata: {
name: 'Test Account',
importTime: Date.now(),
keyring: {
type: 'HD Key Tree',
type: KeyringTypes.hd,
},
nameLastUpdatedAt: Date.now(),
snap: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import BottomSheet, {
import Text, {
TextVariant,
} from '../../../../component-library/components/Texts/Text';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import BannerAlert from '../../../../component-library/components/Banners/Banner/variants/BannerAlert';
import { BannerAlertSeverity } from '../../../../component-library/components/Banners/Banner';
import BottomSheetHeader from '../../../../component-library/components/BottomSheets/BottomSheetHeader';
Expand Down Expand Up @@ -170,56 +170,56 @@ export default function KeyringSnapRemovalWarning({
'app_settings.snaps.snap_settings.remove_account_snap_warning.banner_title',
)}
/>
{showConfirmation ? (
<>
<Text variant={TextVariant.BodyMD} style={styles.description}>
{`${strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_account_snap_alert_description_1',
)} `}
<Text variant={TextVariant.BodyMDBold}>
{snap.manifest.proposedName}
</Text>
{` ${strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_account_snap_alert_description_2',
)}`}
{showConfirmation ? (
<>
<Text variant={TextVariant.BodyMD} style={styles.description}>
{`${strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_account_snap_alert_description_1',
)} `}
<Text variant={TextVariant.BodyMDBold}>
{snap.manifest.proposedName}
</Text>
<TextInput
style={styles.input}
value={confirmationInput}
onChangeText={handleConfirmationInputChange}
testID={KEYRING_SNAP_REMOVAL_WARNING_TEXT_INPUT}
/>
{error && (
<Text variant={TextVariant.BodySM} style={styles.errorText}>
{strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_snap_error',
{
snapName: snap.manifest.proposedName,
},
)}
</Text>
)}
</>
) : (
<>
<Text variant={TextVariant.BodyMD} style={styles.description}>
{` ${strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_account_snap_alert_description_2',
)}`}
</Text>
<TextInput
style={styles.input}
value={confirmationInput}
onChangeText={handleConfirmationInputChange}
testID={KEYRING_SNAP_REMOVAL_WARNING_TEXT_INPUT}
/>
{error && (
<Text variant={TextVariant.BodySM} style={styles.errorText}>
{strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.description',
'app_settings.snaps.snap_settings.remove_account_snap_warning.remove_snap_error',
{
snapName: snap.manifest.proposedName,
},
)}
</Text>
<NativeViewGestureHandler disallowInterruption>
)}
</>
) : (
<>
<Text variant={TextVariant.BodyMD} style={styles.description}>
{strings(
'app_settings.snaps.snap_settings.remove_account_snap_warning.description',
)}
</Text>
<NativeViewGestureHandler disallowInterruption>
<ScrollView style={styles.scrollView}>
{accountListItems}
</ScrollView>
</NativeViewGestureHandler>
</>
)}
</View>
<BottomSheetFooter
style={styles.buttonContainer}
buttonsAlignment={ButtonsAlignment.Horizontal}
buttonPropsArray={buttonPropsArray}
/>
{accountListItems}
</ScrollView>
</NativeViewGestureHandler>
</>
)}
</View>
<BottomSheetFooter
style={styles.buttonContainer}
buttonsAlignment={ButtonsAlignment.Horizontal}
buttonPropsArray={buttonPropsArray}
/>
</BottomSheet>
);
}
Expand Down
11 changes: 6 additions & 5 deletions app/components/Views/Snaps/SnapSettings/SnapSettings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { selectPermissionControllerState } from '../../../../selectors/snaps/per
import KeyringSnapRemovalWarning from '../KeyringSnapRemovalWarning/KeyringSnapRemovalWarning';
import { getAccountsBySnapId } from '../../../../core/SnapKeyring/utils/getAccountsBySnapId';
import { selectInternalAccounts } from '../../../../selectors/accountsController';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import Logger from '../../../../util/Logger';
interface SnapSettingsProps {
snap: Snap;
Expand Down Expand Up @@ -100,7 +100,6 @@ const SnapSettings = () => {
setIsShowingSnapKeyringRemoveWarning(false);
}, []);


const removeSnap = useCallback(async () => {
const { SnapController } = Engine.context;
await SnapController.removeSnap(snap.id);
Expand All @@ -110,8 +109,11 @@ const SnapSettings = () => {
for (const keyringAccount of keyringAccounts) {
await Engine.removeAccount(keyringAccount.address);
}
} catch(error) {
Logger.error(error as Error, 'SnapSettings: failed to remove snap accounts when calling Engine.removeAccount');
} catch (error) {
Logger.error(
error as Error,
'SnapSettings: failed to remove snap accounts when calling Engine.removeAccount',
);
}
}
navigation.goBack();
Expand All @@ -125,7 +127,6 @@ const SnapSettings = () => {
}
}, [isKeyringSnap, keyringAccounts.length, removeSnap]);


const handleRemoveSnapKeyring = useCallback(() => {
try {
setIsShowingSnapKeyringRemoveWarning(true);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
import React, { useCallback } from 'react';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { toChecksumHexAddress } from '@metamask/controller-utils';
import ButtonIcon, {
ButtonIconSizes,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AddressBookControllerState } from '@metamask/address-book-controller';
import { NetworkType } from '@metamask/controller-utils';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import type { NetworkState } from '@metamask/network-controller';
import { Hex } from '@metamask/utils';

Expand Down
2 changes: 1 addition & 1 deletion app/components/hooks/useAccounts/useAccounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
UseAccounts,
UseAccountsParams,
} from './useAccounts.types';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { getChainIdsToPoll } from '../../../selectors/tokensController';
import { useGetFormattedTokensPerChain } from '../useGetFormattedTokensPerChain';
import { useGetTotalFiatBalanceCrossChains } from '../useGetTotalFiatBalanceCrossChains';
Expand Down
2 changes: 1 addition & 1 deletion app/components/hooks/useAccounts/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { getFormattedAddressFromInternalAccount } from '../../../core/Multichain/utils';
import { BigNumber } from 'ethers';
import {
Expand Down
2 changes: 1 addition & 1 deletion app/components/hooks/useGetFormattedTokensPerChain.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import { backgroundState } from '../../util/test/initial-root-state';
import { RootState } from '../../reducers';
import { useGetFormattedTokensPerChain } from './useGetFormattedTokensPerChain';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';

const mockInitialState: DeepPartial<RootState> = {
settings: {},
Expand Down
2 changes: 1 addition & 1 deletion app/components/hooks/useGetFormattedTokensPerChain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
selectCurrentCurrency,
} from '../../selectors/currencyRateController';
import { MarketDataDetails, Token } from '@metamask/assets-controllers';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { isTestNet } from '../../util/networks';
import { selectShowFiatInTestnets } from '../../selectors/settings';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import { backgroundState } from '../../util/test/initial-root-state';
import { RootState } from '../../reducers';
import { useGetTotalFiatBalanceCrossChains } from './useGetTotalFiatBalanceCrossChains';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';

const mockInitialState: DeepPartial<RootState> = {
settings: {},
Expand Down
2 changes: 1 addition & 1 deletion app/components/hooks/useGetTotalFiatBalanceCrossChains.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
selectCurrencyRates,
selectCurrentCurrency,
} from '../../selectors/currencyRateController';
import { InternalAccount } from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import { selectShowFiatInTestnets } from '../../selectors/settings';
import { isTestNet } from '../../util/networks';

Expand Down
7 changes: 6 additions & 1 deletion app/core/Multichain/test/utils.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import {
InternalAccount,
EthAccountType,
BtcAccountType,
EthMethod,
BtcMethod,
EthScopes,
BtcScopes,
} from '@metamask/keyring-api';
import { InternalAccount } from '@metamask/keyring-internal-api';
import {
isEthAccount,
isBtcAccount,
Expand All @@ -28,6 +30,7 @@ const SOL_ADDRESSES = '7EcDhSYGxXyscszYEp35KHN8vvw3svAuLKTzXwCFLtV';
const mockEthEOAAccount: InternalAccount = {
address: MOCK_ETH_ADDRESS,
id: '1',
scopes: [EthScopes.Namespace],
metadata: {
name: 'Eth Account 1',
importTime: 1684232000456,
Expand All @@ -49,6 +52,7 @@ const mockEthEOAAccount: InternalAccount = {
const mockEthERC4337Account: InternalAccount = {
address: '0xC4966c0D659D99699BFD7EB54D8fafEE40e4a756',
id: '1',
scopes: [EthScopes.Namespace],
metadata: {
name: 'Eth Account ERC4337 1',
importTime: 1684232000456,
Expand All @@ -70,6 +74,7 @@ const mockEthERC4337Account: InternalAccount = {
const mockBTCAccount: InternalAccount = {
address: MOCK_BTC_MAINNET_ADDRESS,
id: '1',
scopes: [BtcScopes.Namespace],
metadata: {
name: 'Bitcoin Account',
importTime: 1684232000456,
Expand Down
2 changes: 1 addition & 1 deletion app/core/Multichain/utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { toChecksumHexAddress } from '@metamask/controller-utils';
import { InternalAccount } from '@metamask/keyring-internal-api';
import {
InternalAccount,
EthAccountType,
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
BtcAccountType,
Expand Down
2 changes: 1 addition & 1 deletion app/core/SnapKeyring/BitcoinWalletSnap.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { SnapId } from '@metamask/snaps-sdk';
import { Sender } from '@metamask/keyring-api';
import { Sender } from '@metamask/keyring-snap-client';
import { HandlerType } from '@metamask/snaps-utils';
import { Json, JsonRpcRequest } from '@metamask/utils';
// This dependency is still installed as part of the `package.json`, however
Expand Down
Loading
Loading