Adds signAuthorization method for EIP-7702
#407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
force-pushed
the
feat/sign-authorization
branch
from
5c46e25 to
bb5e268
Compare
jeffsmale90
force-pushed
the
feat/sign-authorization
branch
from
bb5e268 to
b50bc64
Compare
jeffsmale90
commented
Dec 19, 2024
matthewwalsh0
requested changes
Jan 6, 2025
…shuffled non-exported members to the bottom of the file, and renamed a few test constants to aid readability. Also used it.each for multiple test cases.
Contributor
Author
|
@matthewwalsh0 thanks for the review! I made all of the changes you recommended, except for validating chainId !== 0, as I think this should be an API concern, rather than a utility concern, and the redundant "should" in the test names 👀 |
matthewwalsh0
approved these changes
Jan 24, 2025
This was referenced Jan 27, 2025
Merged
github-merge-queue bot
pushed a commit
to MetaMask/accounts
that referenced
this pull request
Feb 5, 2025
… Eth keyrings (#182) EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract. This change integrates the new `signEIP7702Authorization` added to eth-sig-util in MetaMask/eth-sig-util#407 to the eth-simple and eth-hd keyrings. See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details --------- Co-authored-by: Daniel Rocha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-7702 defines a new struct
Authorizationwhich represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract.This change adds methods to hash and sign authorizations, and to recover signer address.
Although the EIP defines the signed authorization as
[chain_id, address, nonce, y_parity, r, s], the utility method returns the signature as a standardr|s|vsignature for consistency with other signing methods.See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details