Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 1, 2023

Was previously part of #288 but broken out pending merge of #290. This proceeds with enabling use of eslint-plugin-promise v43, which will allow users smoother migration experiences.

#288 (comment)

Sample woes undone by this:

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 1, 2023
@legobeat legobeat force-pushed the jsdoc-nodejs-compat branch from a03737d to 936a07f Compare September 1, 2023 06:20
@legobeat legobeat marked this pull request as ready for review September 1, 2023 06:49
@legobeat legobeat requested a review from a team as a code owner September 1, 2023 06:49
@legobeat legobeat requested review from Gudahtt and mcmire September 1, 2023 06:49
@legobeat legobeat force-pushed the jsdoc-nodejs-compat branch from 936a07f to ab79de6 Compare September 1, 2023 08:42
@legobeat legobeat requested review from a team and Mrtenz September 11, 2023 14:10
@legobeat legobeat added the help wanted Extra attention is needed label Sep 11, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 7c43a31 into MetaMask:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants