[assets-contract-controller] Apply messenger pattern and remove inheritance from `BaseControllerV1`#4397

Merged

MajorLift merged 44 commits intomainfrom

240610-upgrade-AssetsContractController

Jul 19, 2024

Commits on Jul 16, 2024

Convert `AssetsContractController` to use messenger pattern without inheriting from `BaseControllerV2`
MajorLift
committed
Fix method returning promise into async function
MajorLift
committed
Explicitly enumerate package-level exports
MajorLift
committed
Adapt tests to use messenger pattern
MajorLift
committed
Narrow iindex signature of `SINGLE_CALL_BALANCES_ADDRESS_BY_CHAINID`
MajorLift
committed
Define messenger actions corresponding to the public methods of `AssetsContractController`
MajorLift
committed
Convert getters for `provider`, `chainId` into private methods
MajorLift
committed
Register action handlers
MajorLift
committed
Replace AssetsContractController constructor options with messenger actions in downstream controllers
MajorLift
committed
Linter fix
MajorLift
committed
Convert class methods into messenger actions
MajorLift
committed
Register class methods as action handlers
MajorLift
committed
Add assets-contract actions as allowed actions to downstream controllers
MajorLift
committed
[assets-contract] Adjust downstream tests to use messenger actions instead of class method callbacks
MajorLift
committed
Pass callbacks into `expect`
MajorLift
committed
Fix `setupAssetContractControllers` so that `useNetworkControllerProvider` option works
MajorLift
committed
Make class fields accessible but immutable by converting to private but exposing getter
MajorLift
committed
fix `NftController` test mock action handlers to be excluded from `options` bag
MajorLift
committed
Replace references to `NetworkController:stateChange` event with `NetworkController:networkDidChange` event
MajorLift
committed
Fix `#getCorrect{Provider,ChainId}` methods so that the methods return up-to-date results by referencing the currently selected network in the network-controller, even if the `networkClientId` para…
MajorLift
committed
Fix `setupAssetContractControllers`, revert unintended changes to `useNetworkControllerProvider` flag behavior
MajorLift
committed
Clean up `AssetsContractController` tests
MajorLift
committed
Fix `BN.isZero()` call that throws error, causing ERC-1155 ownership check to return exception
MajorLift
committed
Fix `NftController` `watchNft` test errors caused by changes to `messenger.call` invocation order
MajorLift
committed
Set `ApprovalController:addRequest` payload `requestData.asset.standard` property fallback value to `suggestedNftMeta.type`
MajorLift
committed
Fix async `expect.rejects.toThrow` call so that the `expect` call is synchronous and its argument is an async callback
MajorLift
committed
Update coverage thresholds
MajorLift
committed
Add `eslint-disable` directive to prevent test from timing out
MajorLift
committed
Adapt `watchNft` tests to new messenger call invocations
MajorLift
committed
Use `getKnownPropertyNames` for iterative `registerActionHandlers` logic
MajorLift
committed
Revert unnecessary changes
MajorLift
committed
Remove unreleased changelog entries
MajorLift
committed
Convert `provider` setter into `setProvider` method
MajorLift
committed
Add jsdoc for `AssetsContractController` types
MajorLift
committed
Fix `#registerActionHandlers`
MajorLift
committed
test(nft-controller): fix messenger call mocks
MajorLift
committed

Commits on Jul 18, 2024

Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift
authored

Commits on Jul 19, 2024

Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift
authored